Ingest 10K [VS-344] #7860
Merged
Ingest 10K [VS-344] #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7860 +/- ##
================================================
Coverage ? 86.296%
Complexity ? 35197
================================================
Files ? 2170
Lines ? 164877
Branches ? 17783
================================================
Hits ? 142282
Misses ? 16271
Partials ? 6324 |
mcovarr
force-pushed
the
vs_344_ingest_10k
branch
from
6b087a3
to
dbe9452
Compare
rsasch
approved these changes
May 19, 2022
Co-authored-by: Bec Asch <[email protected]>
mcovarr
force-pushed
the
vs_344_ingest_10k
branch
from
be8952d
to
85f9259
Compare
gbggrant
approved these changes
May 26, 2022
| @@ -119,7 +119,9 @@ protected void writeJsonArray(int retryCount) throws ExecutionException, Interru | |||
| } | |||
| logger.warn("Caught exception writing to BigQuery, " + (maxRetries - retryCount - 1) + " retries remaining.", e); | |||
| long backOffMillis = backoff.nextBackOffMillis(); | |||
| logger.warn("Sleeping for {} milliseconds before retrying.", backOffMillis); | |||
There was a problem hiding this comment.
I did not know you could use the {} syntax in logger.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a default batch size of 5 since that seemed to work out well in the two Stroke Anderson runs, overridable at the workflow level. Also cleaned up some logging and wrapping exceptions before throwing to avoid confusing stack traces when scanning through logs.