Curate input arrays to skip already ingested sample data [VS-246] #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7862 +/- ##
================================================
Coverage ? 86.290%
Complexity ? 35190
================================================
Files ? 2170
Lines ? 164888
Branches ? 17786
================================================
Hits ? 142282
Misses ? 16281
Partials ? 6325 |
mcovarr
reviewed
May 19, 2022
|
Especially since |
gbggrant
approved these changes
May 23, 2022
| bq --project_id=~{project_id} query --format=csv --use_legacy_sql=false -n ~{num_samples} \ | ||
| "SELECT sample_id, samples.sample_name FROM \`~{dataset_name}.~{table_name}\` AS samples JOIN \`${TEMP_TABLE}\` AS temp ON samples.sample_name=temp.sample_name" > sample_map | ||
| "SELECT sample_id, samples.sample_name FROM \`~{dataset_name}.~{table_name}\` AS samples JOIN \`${TEMP_TABLE}\` AS temp ON samples.sample_name=temp.sample_name WHERE samples.sample_id NOT IN (SELECT sample_id FROM \`~{dataset_name}.sample_load_status\` WHERE status='FINISHED')" > sample_map | ||
|
|
||
| cut -d, -f1 sample_map > gvs_ids |
There was a problem hiding this comment.
Nit:
Might be clearer as:
Suggested change
| cut -d, -f1 sample_map > gvs_ids | |
| cut -d ',' -f1 sample_map > gvs_ids |
gbggrant
approved these changes
Jun 3, 2022
mcovarr
pushed a commit
that referenced
this pull request
Jun 6, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://broadworkbench.atlassian.net/browse/VS-246