Default extract scatter width [VS-415] #7878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7878 +/- ##
================================================
Coverage ? 86.290%
Complexity ? 35195
================================================
Files ? 2170
Lines ? 164888
Branches ? 17785
================================================
Hits ? 142282
Misses ? 16281
Partials ? 6325 |
rsasch
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Looks good, except it failed GvsQuickstartIntegration because the truth VCFs hadn't been updated 😞 : https://job-manager.dsde-prod.broadinstitute.org/jobs/7f4b71b4-03a0-4648-aee5-4fc5c3ea575c
…t_extract_scatter_width
RoriCremer
reviewed
Jun 6, 2022
| @@ -15,7 +15,7 @@ workflow GvsExtractCallset { | |||
| String extract_table_prefix | |||
| String filter_set_name | |||
| String query_project = project_id | |||
| Int scatter_count | |||
| Int? scatter_count | |||
There was a problem hiding this comment.
do we want to provide a comment that no default is needed since it is calculated now during the workflow
There was a problem hiding this comment.
Sure I could do that here.
RoriCremer
approved these changes
Jun 6, 2022
|
Now integration tested successfully here. |
gbggrant
approved these changes
Jun 6, 2022
rsasch
approved these changes
Jun 8, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.