Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quickstart Integration for X/Y scaling changes [VS-464] #7881

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jun 3, 2022

Updates expectations for the X/Y scaling changes that went in a couple of weeks ago and slip in a few unrelated minor improvements.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@db90162). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7881   +/-   ##
================================================
  Coverage                ?   86.291%           
  Complexity              ?     35196           
================================================
  Files                   ?      2170           
  Lines                   ?    164888           
  Branches                ?     17785           
================================================
  Hits                    ?    142284           
  Misses                  ?     16280           
  Partials                ?      6324           

@mcovarr mcovarr force-pushed the vs_464_update_quickstart_integration branch from 9894e4b to ee35b66 Compare June 6, 2022 11:30
@mcovarr mcovarr marked this pull request as ready for review June 6, 2022 15:36
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a run of the integration test for this branch?

@mcovarr
Copy link
Collaborator Author

mcovarr commented Jun 8, 2022

do you have a run of the integration test for this branch?

Yup, this run utilized this vs_464_update_quickstart_integration branch to test the vs_415_default_extract_scatter_width changes.

@mcovarr mcovarr force-pushed the vs_464_update_quickstart_integration branch from ee35b66 to a2ca908 Compare June 8, 2022 20:55
@mcovarr mcovarr requested a review from rsasch June 8, 2022 21:13
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good — thanks!

@mcovarr mcovarr force-pushed the vs_464_update_quickstart_integration branch from a2ca908 to 6832b54 Compare June 9, 2022 14:34
@mcovarr mcovarr merged commit 7dca9fb into ah_var_store Jun 9, 2022
@mcovarr mcovarr deleted the vs_464_update_quickstart_integration branch June 9, 2022 16:42
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants