VS 483 Beta user wdl #7894
Merged
VS 483 Beta user wdl #7894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
force-pushed
the
rc-vs-483-beta-user-wdl
branch
from
78324dc
to
bf7675e
Compare
mcovarr
reviewed
Jun 13, 2022
mcovarr
reviewed
Jun 13, 2022
|
|
||
| import "GvsUnified.wdl" as Unified | ||
|
|
||
| workflow GvsVariantCalling { |
There was a problem hiding this comment.
Is the idea that this is what we will use for the beta workspace?
RoriCremer
force-pushed
the
rc-vs-483-beta-user-wdl
branch
from
811ab96
to
bc1b4d0
Compare
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7894 +/- ##
================================================
Coverage ? 86.288%
Complexity ? 35194
================================================
Files ? 2170
Lines ? 164888
Branches ? 17785
================================================
Hits ? 142278
Misses ? 16288
Partials ? 6322 |
Merged
RoriCremer
force-pushed
the
rc-vs-483-beta-user-wdl
branch
from
260704f
to
3fbcaed
Compare
RoriCremer
force-pushed
the
rc-vs-483-beta-user-wdl
branch
from
3fbcaed
to
0aaf719
Compare
RoriCremer
commented
Jun 21, 2022
RoriCremer
commented
Jun 24, 2022
kcibul
reviewed
Jun 24, 2022
|
|
||
| String extract_output_file_base_name = sub(callset_identifier, "\s+|\_+", "-") | ||
| String extract_table_prefix = sub(callset_identifier, "\s+|\_+", "-") | ||
| if(false) { |
There was a problem hiding this comment.
This seems unusual -- can you add a comment as to why this is necessary?
There was a problem hiding this comment.
yes! it's because I'm obnoxiously asking the user to come up with a name that I will use for the filter set name, and the prepare table names and the exported vcf / interval lists names, so I dont want any spaces
There was a problem hiding this comment.
i'll add a comment to the code too (!)
kcibul
approved these changes
Jun 24, 2022
rsasch
reviewed
Jun 28, 2022
| Array[String] external_sample_names | ||
| Array[File] input_vcfs | ||
| Array[File] input_vcf_indexes | ||
| String callset_identifier |
There was a problem hiding this comment.
nit: I believe elsewhere we are using "call_set_identifier"
RoriCremer
added a commit
that referenced
this pull request
Jun 29, 2022
* create wrapper wdl for Beta users * update dockstore * remove dead old readme * update readme to be used by beta users * okay i thought i deleted this * update naming * update sample set creation * make wom happy * update dockstore * short term remove dir * remove samples_are_controls from unified * pr revisions * make the many optional inputs go away * dont allow illegal names * remove done tag * add public jar * remove superfluous file * dont allow spaces in filter set name either * correct the regex * rename callset id
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrapper WDL that cuts down on excess params for our Beta users