Workflow compute costs [VS-472] #7905
Conversation
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7905 +/- ##
================================================
Coverage ? 86.291%
Complexity ? 35192
================================================
Files ? 2170
Lines ? 164888
Branches ? 17786
================================================
Hits ? 142283
Misses ? 16281
Partials ? 6324 |
mcovarr
force-pushed
the
vs_472_workflow_compute_costs
branch
from
61a8945
to
a99d2ae
Compare
|
Added some sample output to the associated JIRA ticket. |
|
|
||
| if workflow_name.startswith('Gvs'): | ||
| if len(workflow_ids) == 1: | ||
| # If this run is < 1 day old the cost data may not yet be available. |
There was a problem hiding this comment.
Is it that the cost data might not be available - or is it that it might be not yet up-to-date? Perhaps put a general warning if the run is < 1 day old to tell the user that they might want to run this later just to be sure that cost is correct?
There was a problem hiding this comment.
I think this usually happens when this code runs too soon after the workflow completes.
I am capturing this message in a logfile but now that you bring this up I'm wondering if that's really a place that the users of this code would actually look; we should probably discuss as a team the best way to represent this condition so users can make an informed choice as to whether instances of this situation are okay or not.
There was a problem hiding this comment.
per mob discussion we're going to use this as is for now
Includes some of VS-441's driver WDL with the parts that are not workflow compute costs commented out. Successful run here: https://job-manager.dsde-prod.broadinstitute.org/jobs/2837665e-6903-4dc5-b9e1-418739d9c837