Read cost observability table [VS-475] #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7923 +/- ##
================================================
Coverage ? 86.286%
Complexity ? 35188
================================================
Files ? 2170
Lines ? 164888
Branches ? 17786
================================================
Hits ? 142276
Misses ? 16289
Partials ? 6323 |
rsasch
reviewed
Jun 30, 2022
| > cost_observability.json | ||
| >>> | ||
| runtime { | ||
| docker: "gcr.io/google.com/cloudsdktool/cloud-sdk:390.0.0" |
There was a problem hiding this comment.
We should have a team agreement on this - I would think we'd want to stick with known versions for repeatability?
There was a problem hiding this comment.
We had an issue in Batch when we used 'latest' and that upgraded to a version with a bug that broke our CI in a weird way
rsasch
approved these changes
Jun 30, 2022
gbggrant
approved these changes
Jun 30, 2022
| > cost_observability.json | ||
| >>> | ||
| runtime { | ||
| docker: "gcr.io/google.com/cloudsdktool/cloud-sdk:390.0.0" |
There was a problem hiding this comment.
We should have a team agreement on this - I would think we'd want to stick with known versions for repeatability?
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the
cost_observabilitytable for the specifiedproject_id/dataset_name/call_set_identifierand sums up the associated event bytes: