Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few last doc changes #7927

Merged
merged 14 commits into from
Jul 25, 2022
Merged

A few last doc changes #7927

merged 14 commits into from
Jul 25, 2022

Conversation

RoriCremer
Copy link
Contributor

@RoriCremer RoriCremer commented Jul 1, 2022

adding time and cost estimates to the documentation

@RoriCremer RoriCremer force-pushed the rc_last_doc_changes branch 3 times, most recently from 8ee25b2 to 21be0d7 Compare July 1, 2022 15:42
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@28ed209). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7927   +/-   ##
================================================
  Coverage                ?   86.247%           
  Complexity              ?     35200           
================================================
  Files                   ?      2173           
  Lines                   ?    165016           
  Branches                ?     17793           
================================================
  Hits                    ?    142321           
  Misses                  ?     16368           
  Partials                ?      6327           

@RoriCremer RoriCremer marked this pull request as ready for review July 21, 2022 19:31
@RoriCremer RoriCremer merged commit 2d1e304 into ah_var_store Jul 25, 2022
@RoriCremer RoriCremer deleted the rc_last_doc_changes branch July 25, 2022 16:22
@@ -2,17 +2,17 @@

| Workflow Version | Date Updated | Documentation Authors | Questions or Feedback |
| :----: | :---: | :----: | :--------------: |
| [GvsJointVariantCalling](https://github.com/broadinstitute/gatk/blob/rc-vs-483-beta-user-wdl/scripts/variantstore/wdl/GvsJointVariantCalling.wdl) | June, 2022 | [Kaylee Mathews](mailto:[email protected]) and [Aurora Cremer](mailto:[email protected]) | If you have questions or feedback, contact the [Broad Variants team](mailto:[email protected]) |
| [GvsJointVariantCalling](https://github.com/broadinstitute/gatk/blob/ah_var_store/scripts/variantstore/wdl/GvsJointVariantCalling.wdl) | June, 2022 | [Kaylee Mathews](mailto:[email protected]) and [Aurora Cremer](mailto:[email protected]) | If you have questions or feedback, contact the [Broad Variants team](mailto:[email protected]) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we want this pinned to a particular release so that it doesn't change out from under users?

| 10379 | 05:38:00 | $683.33 | $0.0658 |
| Number of Samples | Elapsed Time (hh:mm) | Terra Cost | BigQuery Cost | Total Cost | Approximate Cost per Sample |
|-------------------|----------------------|------------|---------------|------------|-----------------------------|
| 10 | 04:30 | $0.84 | $0.51 | $1.35 | $0.14 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had run this on other sets that were larger than this to provide more cost information?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see those are in a different document and this is just for the quickstart. Nvm!

@kayleemathews kayleemathews restored the rc_last_doc_changes branch September 1, 2022 17:39
@kayleemathews kayleemathews deleted the rc_last_doc_changes branch September 1, 2022 17:45
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants