VS_492 - Beta User Jar release #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successful joint genoytping run here: https://app.terra.bio/#workspaces/gvs-dev/GVS%20Quickstart%20v3%20ggrant/job_history/90b934d7-27dc-4745-9230-e89d4bd77e3e |
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7934 +/- ##
================================================
Coverage ? 86.241%
Complexity ? 35198
================================================
Files ? 2173
Lines ? 165003
Branches ? 17793
================================================
Hits ? 142300
Misses ? 16377
Partials ? 6326 |
rsasch
requested changes
Jul 11, 2022
|
Thanks - I've made the change. |
mcovarr
reviewed
Jul 11, 2022
| @@ -214,7 +214,7 @@ task CreateCostObservabilityTable { | |||
| fi | |||
| >>> | |||
| runtime { | |||
| docker: "us.gcr.io/broad-dsde-methods/variantstore:rsa_metadata_from_python_20220628" | |||
| docker: "us.gcr.io/broad-dsde-methods/variantstore:ah_var_store_2022_07_08" | |||
There was a problem hiding this comment.
are we sure our users will have access to this image? and/or is it public?
There was a problem hiding this comment.
poked around the methods GCR / GCS bucket and it and all images within it appears to be public
There was a problem hiding this comment.
us.gcr.io/broad-dsde-methods/variantstore is publicly accessible.
mcovarr
approved these changes
Jul 11, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have updated the gatk override jar with a fresh build (ah_var_store on 7/8/2022)
And updated the docker similarly.