Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gg_VS-513. Remove usage of service account from GvsValidateVAT.wdl #7937

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

gbggrant
Copy link
Collaborator

No description provided.

@gbggrant
Copy link
Collaborator Author

'Passing' workflow at: https://app.terra.bio/#workspaces/allofus-drc-wgs-dev/AoU_DRC_WGS_12-6-21_beta_ingest/job_history/e51afc46-ef55-4c59-b4dd-6ab7d3de0ca8

Note that this workflow fails because one of the actual validations fails, so the report that is generated indicates this

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@63108be). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7937   +/-   ##
================================================
  Coverage                ?   86.240%           
  Complexity              ?     35192           
================================================
  Files                   ?      2173           
  Lines                   ?    165003           
  Branches                ?     17794           
================================================
  Hits                    ?    142298           
  Misses                  ?     16378           
  Partials                ?      6327           

@gbggrant
Copy link
Collaborator Author

I've run this with my pmi ops account using these parameters:
default_dataset: "beta2_99k"
query_project_id: aou-genomics-curation-prod"
vat_table_name: "vat_v3"

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run at least the first task in the workflow without a service account

@gbggrant gbggrant merged commit de4479a into ah_var_store Jul 15, 2022
@gbggrant gbggrant deleted the gg_NoSa branch July 15, 2022 17:27
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants