clearer error when values are missing #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #7939 +/- ##
================================================
Coverage ? 86.241%
Complexity ? 35201
================================================
Files ? 2173
Lines ? 165016
Branches ? 17792
================================================
Hits ? 142311
Misses ? 16378
Partials ? 6327 |
mcovarr
approved these changes
Jul 25, 2022
| @@ -990,29 +990,38 @@ task ClinvarSignificance { | |||
| # "other", | |||
| # "not provided"] | |||
|
|
|||
| bq query --nouse_legacy_sql --project_id=~{query_project_id} --format=csv 'SELECT | |||
| bq query --nouse_legacy_sql --project_id=~{query_project_id} --format=csv 'SELECT | |||
|
|
||
| echo "false" > ~{pf_file} | ||
| # if the result of the query has any rows, that means gvs_all_an has not been calculated correctly | ||
| if [[ $NUMRESULTS -ge 13 && $INCLUVALUES = "0" ]]; then | ||
| # if the result of the query less than 13 rows, that means clinvar_classification must not have all the expected values |
There was a problem hiding this comment.
Suggested change
| # if the result of the query less than 13 rows, that means clinvar_classification must not have all the expected values | |
| # If the result of the query has fewer than 13 rows, that means clinvar_classification must not have all the expected values. |
| # if the result of the query has any rows, that means gvs_all_an has not been calculated correctly | ||
| if [[ $NUMRESULTS -ge 13 && $INCLUVALUES = "0" ]]; then | ||
| # if the result of the query less than 13 rows, that means clinvar_classification must not have all the expected values | ||
| if [[ $NUMRESULTS -ge 13 && $NUMMISS = "0" ]]; then |
There was a problem hiding this comment.
Suggested change
| if [[ $NUMRESULTS -ge 13 && $NUMMISS = "0" ]]; then | |
| if [[ $NUMRESULTS -ge 13 && $NUMMISS -eq 0 ]]; then |
| index($0,"not provided"))}' bq_clinvar_classes.csv) | ||
| ~{fq_vat_table}, UNNEST(clinvar_classification) AS unnested_clinvar_classification'| sed "2 d" > bq_clinvar_classes.csv | ||
|
|
||
| echo "affects" >> expected_clinvar_classes.csv |
There was a problem hiding this comment.
TOL this could be DRYed
echo 'affects
association
benign
.
.
.
uncertain significance' > expected_clinvar_classes.csv
gbggrant
approved these changes
Jul 26, 2022
RoriCremer
force-pushed
the
rc-update-clinvar-validate-vat
branch
from
f12853c
to
7238988
Compare
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the VAT validation, give clearer error msg about which clinvar classification values are missing