Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost WDL should throw on FISS API errors [VS-518] #7942

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jul 13, 2022

% python3 workflow_compute_costs.py \
    --workspace_namespace 'not' \                            
    --workspace_name 'there'                
Traceback (most recent call last):
  File "workflow_compute_costs.py", line 135, in <module>
    costs = compute_costs(args.workspace_namespace, args.workspace_name, args.exclude)
  File "workflow_compute_costs.py", line 32, in compute_costs
    submissions = list_submissions(workspace_namespace, workspace_name)
  File "workflow_compute_costs.py", line 14, in fapi_list_submissions
    return fapi_error_check(fapi.list_submissions(workspace_namespace, workspace_name))
  File "workflow_compute_costs.py", line 8, in fapi_error_check
    raise Exception(j['message'])
Exception: workspace not/there does not exist or you do not have permission to use it

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@201df7f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7942   +/-   ##
================================================
  Coverage                ?   86.240%           
  Complexity              ?     35197           
================================================
  Files                   ?      2173           
  Lines                   ?    165003           
  Branches                ?     17793           
================================================
  Hits                    ?    142298           
  Misses                  ?     16378           
  Partials                ?      6327           

@mcovarr mcovarr force-pushed the vs_518_throw_on_fiss_api_error branch from 1ae3cc2 to da6f043 Compare July 13, 2022 18:18
@@ -59,16 +58,15 @@ task WorkflowComputeCosts {
--workspace_namespace '~{workspace_namespace}' \
--workspace_name '~{workspace_name}' \
~{sep=' ' excluded_ids} \
> costs_by_workflow.json 2> workflow_compute_costs.log
> costs_by_workflow.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let errors go to stderr where users can more easily see them in the job logs

@mcovarr mcovarr merged commit c00e54b into ah_var_store Jul 14, 2022
@mcovarr mcovarr deleted the vs_518_throw_on_fiss_api_error branch July 14, 2022 10:23
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants