Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More import retries [VS-532] #7953

Merged
merged 2 commits into from
Jul 21, 2022
Merged

More import retries [VS-532] #7953

merged 2 commits into from
Jul 21, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jul 20, 2022

No description provided.

@mcovarr mcovarr changed the title Moar gvs import retries More import retries [VS-532] Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@210a6ae). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7953   +/-   ##
================================================
  Coverage                ?   86.247%           
  Complexity              ?     35205           
================================================
  Files                   ?      2173           
  Lines                   ?    165016           
  Branches                ?     17792           
================================================
  Hits                    ?    142321           
  Misses                  ?     16368           
  Partials                ?      6327

RoriCremer
RoriCremer approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@RoriCremer RoriCremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any drawback to them being so high? Maybe just a small additional cost risk?

@mcovarr
Copy link
Collaborator Author

mcovarr commented Jul 20, 2022 •
edited
Loading

Is there any drawback to them being so high? Maybe just a small additional cost risk?

If the import fails non-transiently (BQ becomes unavailable or perhaps a bug is introduced during development) the import could be retried many times. But even in this scenario the VM wouldn't be up very long before exiting non-0 so I don't think this is a significant risk.

@mcovarr mcovarr merged commit 28ed209 into ah_var_store Jul 21, 2022
@mcovarr mcovarr deleted the moar_gvs_import_retries branch July 21, 2022 16:09
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasch rsasch rsasch approved these changes

@gbggrant gbggrant gbggrant approved these changes

@RoriCremer RoriCremer RoriCremer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcovarr @rsasch @gbggrant @RoriCremer