-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Upgrade htsjdk to v3.0.0. (#7867)" #7960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 merge when tests pass
Codecov Report
@@ Coverage Diff @@
## master #7960 +/- ##
===============================================
- Coverage 87.089% 87.063% -0.026%
- Complexity 36993 37013 +20
===============================================
Files 2217 2218 +1
Lines 173847 173760 -87
Branches 18791 18769 -22
===============================================
- Hits 151402 151281 -121
- Misses 15816 15893 +77
+ Partials 6629 6586 -43
|
lbergelson
added a commit
that referenced
this pull request
Sep 19, 2022
lbergelson
added a commit
that referenced
this pull request
Oct 12, 2022
This upgrades htsjdk h was attempted in #7867 and then reverted in #7960 in order to unblock the jukebox merge. * upgrade htsjdk 2.24.1 -> 3.0.1 * upgrade picard 2.27.1 -> 2.27.5 Co-authored-by: David Roazen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ace7821. This is a necessary step in order for #7876 to be merged. We will re-instate this branch after that is merged.