Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade htsjdk to v3.0.0. (#7867)" #7960

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

jamesemery
Copy link
Collaborator

This reverts commit ace7821. This is a necessary step in order for #7876 to be merged. We will re-instate this branch after that is merged.

This reverts commit ace7821. This is a necessary step in order for #7876 to be merged
@jamesemery jamesemery requested a review from droazen July 21, 2022 18:50
Copy link
Collaborator

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merge when tests pass

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #7960 (ec9d1b6) into master (ace7821) will decrease coverage by 0.026%.
The diff coverage is 85.714%.

@@               Coverage Diff               @@
##              master     #7960       +/-   ##
===============================================
- Coverage     87.089%   87.063%   -0.026%     
- Complexity     36993     37013       +20     
===============================================
  Files           2217      2218        +1     
  Lines         173847    173760       -87     
  Branches       18791     18769       -22     
===============================================
- Hits          151402    151281      -121     
- Misses         15816     15893       +77     
+ Partials        6629      6586       -43     
Impacted Files Coverage Δ
...bender/tools/funcotator/StrandCorrectedAllele.java 0.000% <ø> (ø)
...nstitute/hellbender/utils/haplotype/Haplotype.java 90.244% <ø> (ø)
...kers/haplotypecaller/AssemblyBasedCallerUtils.java 90.558% <80.000%> (+0.041%) ⬆️
...itute/hellbender/engine/spark/GATKRegistrator.java 100.000% <100.000%> (ø)
...er/tools/spark/sv/evidence/BreakpointEvidence.java 66.822% <0.000%> (-12.383%) ⬇️
...ute/hellbender/utils/reference/ReferenceUtils.java 73.529% <0.000%> (-5.418%) ⬇️
...on/FindBreakpointEvidenceSparkIntegrationTest.java 96.296% <0.000%> (-3.704%) ⬇️
.../hellbender/utils/python/PythonUnitTestRunner.java 75.410% <0.000%> (-3.279%) ⬇️
...rg/broadinstitute/hellbender/utils/SVInterval.java 90.000% <0.000%> (-2.857%) ⬇️
...ute/hellbender/tools/spark/utils/IntHistogram.java 86.335% <0.000%> (-2.484%) ⬇️
... and 18 more

@jamesemery jamesemery merged commit 5f9f12b into master Jul 22, 2022
@jamesemery jamesemery deleted the je_revertHtsjdkUpdate branch July 22, 2022 14:04
lbergelson added a commit that referenced this pull request Sep 19, 2022
lbergelson added a commit that referenced this pull request Sep 19, 2022
This upgrades htsjdk to v3.0.0 which was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.
lbergelson added a commit that referenced this pull request Oct 12, 2022
This upgrades htsjdk to v3.0.0 which was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.
lbergelson added a commit that referenced this pull request Oct 12, 2022
This upgrades htsjdk h was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.

* upgrade htsjdk 2.24.1 -> 3.0.1
* upgrade picard 2.27.1 -> 2.27.5

Co-authored-by: David Roazen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants