Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table size check to quickstart integration test [VS-501] #7970

Merged
merged 9 commits into from
Aug 3, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Aug 2, 2022

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@3e62331). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7970   +/-   ##
================================================
  Coverage                ?   79.221%           
  Complexity              ?     33311           
================================================
  Files                   ?      2173           
  Lines                   ?    165016           
  Branches                ?     17793           
================================================
  Hits                    ?    130727           
  Misses                  ?     28117           
  Partials                ?      6172           

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion.

scripts/variantstore/wdl/GvsQuickstartIntegration.wdl Outdated Show resolved Hide resolved
set -o xtrace

echo "project_id = ~{project_id}" > ~/.bigqueryrc
bq query --location=US --project_id=~{project_id} --format=csv --use_legacy_sql=false \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOL I think if you start the double quote on this line you could get rid of all the trailing backslashes. Maybe.

@rsasch rsasch merged commit de42a7a into ah_var_store Aug 3, 2022
@rsasch rsasch deleted the rsa_vs_501_add_size_check branch August 3, 2022 17:54
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants