Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document steps for GVS cleanup for base use case [VS-586] #7989

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Aug 15, 2022

Documents steps to clean up GVS assets in the following use case:

  • the samples in the callset are going to be joint called once (no sub-cohorts, no re-using the model)
  • the outputs (VCFs, indexes, interval lists, manifest, sample name list) have all been copied to an independent location (not in the workspace bucket)
  • no need to maintain provenance
  • the workspace where the pipeline was run is only being used for this GVS callset

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@0130bb8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7989   +/-   ##
================================================
  Coverage                ?   86.241%           
  Complexity              ?     35201           
================================================
  Files                   ?      2173           
  Lines                   ?    165016           
  Branches                ?     17792           
================================================
  Hits                    ?    142311           
  Misses                  ?     16378           
  Partials                ?      6327           

@rsasch rsasch requested a review from kbergin August 15, 2022 20:16
Copy link
Collaborator

@kbergin kbergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I have one suggestion :)

scripts/variantstore/beta_docs/gvs-cleanup.md Show resolved Hide resolved
@rsasch rsasch requested a review from kbergin August 17, 2022 15:21
@rsasch rsasch merged commit bed8af2 into ah_var_store Aug 17, 2022
@rsasch rsasch deleted the rsa_vs_586_cleanup_docs branch August 17, 2022 16:45
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants