Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Hail import/export script [VS-605] #8002

Merged
merged 20 commits into from
Aug 26, 2022
Merged

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Aug 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@0d914c5). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8002   +/-   ##
================================================
  Coverage                ?   86.242%           
  Complexity              ?     35202           
================================================
  Files                   ?      2173           
  Lines                   ?    165016           
  Branches                ?     17792           
================================================
  Hits                    ?    142313           
  Misses                  ?     16377           
  Partials                ?      6326           

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why no last modified checks? Was it to keep the code simpler?

@mcovarr
Copy link
Collaborator Author

mcovarr commented Aug 25, 2022

Just curious, why no last modified checks? Was it to keep the code simpler?

Mostly because I couldn't readily think of a scenario where I would actually want this to call cache, but I could easily imagine call caching leading to undesired clobbering of previously generated results. We can certainly revisit this decision if it turns out we're using the script in ways where we really would want call caching.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Only suggestion is to maybe change the comments explaining why the tasks are volatile from "there's no last modified check" to something like "we don't envision taking advantage of call caching at the moment".

@mcovarr mcovarr merged commit d3f63e5 into ah_var_store Aug 26, 2022
@mcovarr mcovarr deleted the vs_605_hail_codegen branch August 26, 2022 11:10
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants