Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File of callset samples -> samples marked as 'withdrawn' in GVS [VS-436] #8009

Merged
merged 13 commits into from
Sep 8, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Sep 1, 2022

Given a list of samples for a callset, withdraw samples from GVS that are not included by marking them as 'withdrawn' in the sample_info table with a passed in timestamp.

Test run here: https://app.terra.bio/#workspaces/gvs-dev/RSA%20-%20GVS%20Quickstart%20V2%20/job_history/568919e6-3c51-4ce9-978c-75ffc5ff9997

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@91c9c9c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8009   +/-   ##
================================================
  Coverage                ?   42.466%           
  Complexity              ?     23462           
================================================
  Files                   ?      2173           
  Lines                   ?    165004           
  Branches                ?     17791           
================================================
  Hits                    ?     70070           
  Misses                  ?     89631           
  Partials                ?      5303           

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't overwrite existing withdrawn dates, otherwise looks good

@rsasch rsasch requested a review from mcovarr September 8, 2022 15:06
@rsasch rsasch merged commit 08c1ad7 into ah_var_store Sep 8, 2022
@rsasch rsasch deleted the rsa_vs_436_withdrawn_wdl branch September 8, 2022 19:00
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants