Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the number of CPUs to request from Google quotas for AoU callsets #8016

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Sep 8, 2022

D'oh

@@ -25,7 +25,7 @@
- **NOTE** If you want to create a large sample set after you have run the notebook, Terra provides (and recommends you use) this python [script](https://github.com/broadinstitute/firecloud-tools/tree/master/scripts/import_large_tsv) which allows you to upload a sample set to the workspace.
- **TBD This is based on VCF output; VDS output might need different increases.** For extracting VCFs as the final output for the callset, you will want to increase the Google quotas for the workspace project (you can find this in the workspace dashboard under Cloud Information > Google Project ID) to these levels (all in the workspace region):
- Persistent Disk Standard (GB): 1,000,000 GB (1 PB)
- CPUs: 64,000
- CPUs: 6,400
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From poking around the history it looks like this has always been 64,000, though never having done a mega callset I defer to you as to which is correct. 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiiinteresting

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: I requested 64,000 VM instances for the intermediate callset but actually got 640,000 (!)

Screen Shot 2022-09-09 at 11 18 41 AM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 maybe that's the reason Google started cracking down....

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@@ -25,7 +25,7 @@
- **NOTE** If you want to create a large sample set after you have run the notebook, Terra provides (and recommends you use) this python [script](https://github.com/broadinstitute/firecloud-tools/tree/master/scripts/import_large_tsv) which allows you to upload a sample set to the workspace.
- **TBD This is based on VCF output; VDS output might need different increases.** For extracting VCFs as the final output for the callset, you will want to increase the Google quotas for the workspace project (you can find this in the workspace dashboard under Cloud Information > Google Project ID) to these levels (all in the workspace region):
- Persistent Disk Standard (GB): 1,000,000 GB (1 PB)
- CPUs: 64,000
- CPUs: 6,400
- In-use IP addresses: 5,000 (this is the most challenging one and will probably require contacting the GCP account team to facilitate)
- VM instances: 64,000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change too? It might keep us off Google's naughty list and we don't use fractional CPUs anyway.

Copy link
Author

@rsasch rsasch Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked the quotas for the Charlie workspace project, CPUs was 6,400 and VM instances was 64,000 so I kept this one the same.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@08c1ad7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8016   +/-   ##
================================================
  Coverage                ?   86.243%           
  Complexity              ?     35196           
================================================
  Files                   ?      2173           
  Lines                   ?    165004           
  Branches                ?     17792           
================================================
  Hits                    ?    142304           
  Misses                  ?     16373           
  Partials                ?      6327           

@rsasch rsasch merged commit d52f05d into ah_var_store Sep 9, 2022
@rsasch rsasch deleted the rsa_fix_CPUs_quota branch September 9, 2022 14:40
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants