Add in ability to tweak sample-every-Nth-variant parameter for SNP model creation #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in PopulateFilterSetInfo
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8019 +/- ##
================================================
Coverage ? 86.244%
Complexity ? 35197
================================================
Files ? 2173
Lines ? 165004
Branches ? 17792
================================================
Hits ? 142306
Misses ? 16372
Partials ? 6326 |
RoriCremer
reviewed
Sep 14, 2022
| @@ -23,9 +23,11 @@ task SNPsVariantRecalibratorCreateModel { | |||
| File dbsnp_resource_vcf_index | |||
| Boolean use_allele_specific_annotations | |||
| Int max_gaussians = 6 | |||
| Int sample_every_nth_variant = 1 | |||
There was a problem hiding this comment.
Is this gonna override this value being set in the filter wdl?
There was a problem hiding this comment.
This is a default because the input in GvsCreateFilterSet (which sets this value) is optional.
gbggrant
approved these changes
Sep 15, 2022
| @@ -398,14 +403,15 @@ task PopulateFilterSetInfo { | |||
| runtime { | |||
| docker: "us.gcr.io/broad-dsde-methods/broad-gatk-snapshots:varstore_d8a72b825eab2d979c8877448c0ca948fd9b34c7_change_to_hwe" | |||
| memory: "3500 MB" | |||
| disks: "local-disk 200 HDD" | |||
| disks: "local-disk 250 HDD" | |||
There was a problem hiding this comment.
Disk is cheap - why not 500?
koncheto-broad
approved these changes
Sep 15, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://broadworkbench.atlassian.net/browse/VS-624