VS-517 Use standard version of GetBQTableLastModifiedDatetime in GvsValidateVat #8024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLastModifiedDatetime
Catching it up to ah_var_store for easier merging in pr
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8024 +/- ##
================================================
Coverage ? 86.240%
Complexity ? 35196
================================================
Files ? 2173
Lines ? 165004
Branches ? 17792
================================================
Hits ? 142300
Misses ? 16376
Partials ? 6328 |
mcovarr
approved these changes
Sep 20, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replaced a custom version of the task with a standard one we are using elsewhere
Original run:
https://app.terra.bio/#workspaces/gvs-dev/GVS%20Quickstart%20v3%20hatcher/job_history/193c7c2b-2d29-4bab-8abc-6ab85a2f5270
Run from the modified branch:
https://app.terra.bio/#workspaces/gvs-dev/GVS%20Quickstart%20v3%20hatcher/job_history/575121f1-07e9-4821-bb20-35b6ed430560
Both ran within my quickstart workspace, but were pointed at George's dataset. Both failed the same two predicted tasks.