Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-665 and VS-620 updating code to use latest docker images containing Rori's AD calculation changes in extract #8061

Merged
merged 12 commits into from
Oct 18, 2022

Conversation

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@2a8c210). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8061   +/-   ##
================================================
  Coverage                ?   77.048%           
  Complexity              ?     21714           
================================================
  Files                   ?      1375           
  Lines                   ?     82250           
  Branches                ?     13121           
================================================
  Hits                    ?     63372           
  Misses                  ?     13749           
  Partials                ?      5129           

@koncheto-broad
Copy link
Author

Most are straightforward docker image swaps, with two exceptions.

  1. GVSAsssignIDs was able to move to a much smaller docker image due to it not actually using GATK.
  2. GVSImportGenomes couldn't use an alpine docker image due to the -d option in split, so I got rid of the -d option. Turns out, it runs fine without it so I could update it to an alpine image.

@koncheto-broad koncheto-broad merged commit bde383b into ah_var_store Oct 18, 2022
@koncheto-broad koncheto-broad deleted the VS-620 branch October 18, 2022 17:29
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants