VS-665 updating beta workflow to use changes tested in quickstart #8062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion of GATK George tested against the workflow
mcovarr
approved these changes
Oct 18, 2022
| @@ -35,7 +35,8 @@ workflow GvsJointVariantCalling { | |||
| Int SNP_VQSR_max_gaussians_override = 6 | |||
| Int SNP_VQSR_mem_gb_override = "" | |||
| } | |||
| File gatk_override = "gs://gvs_quickstart_storage/jars/gatk-package-4.2.0.0-613-g1219576-SNAPSHOT-local.jar" | |||
| # This is the most updated snapshot of the code as of Oct 18, 2022 | |||
| File gatk_override = "gs://gvs_quickstart_storage/jars/gatk-package-4.2.0.0-625-g950122c-SNAPSHOT-local.jar" | |||
There was a problem hiding this comment.
we should probably update the jarmaking script to work the date in there but that's for another ticket / PR
There was a problem hiding this comment.
Agreed. I added in this comment with the date precisely because I noticed the date wasn't present in the jar, but it won't be necessary once we update that jar script to add it into the filename
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8062 +/- ##
================================================
Coverage ? 16.944%
Complexity ? 4702
================================================
Files ? 1375
Lines ? 82077
Branches ? 13014
================================================
Hits ? 13907
Misses ? 66109
Partials ? 2061 |
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the beta workflow to use the latest jar, representing the version of GATK tested against the quickstart workflow