Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Alpinizing of apt dependent task [VS-688] #8065

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Oct 20, 2022

Integration run here.

As written the task requires apt-get. Converting this to Alpine would be non-trivial and not really worthwhile as it might even take longer to build all the extra things into the alpine image that we simply download with the slim image.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good — thanks!

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@f2dcc68). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8065   +/-   ##
================================================
  Coverage                ?   86.249%           
  Complexity              ?     35201           
================================================
  Files                   ?      2173           
  Lines                   ?    165041           
  Branches                ?     17794           
================================================
  Hits                    ?    142346           
  Misses                  ?     16369           
  Partials                ?      6326           

@gatk-bot
Copy link

Github actions tests reported job failures from actions build 3291130285
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 11 3291130285.11 logs

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcovarr mcovarr merged commit 4c8abaa into ah_var_store Oct 20, 2022
@mcovarr mcovarr deleted the vs_688_fix_integration_for_alpine branch October 20, 2022 17:46
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants