Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration expectations for fixed AD [VS-689] #8066

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fix integration expectations for fixed AD [VS-689] #8066

merged 3 commits into from
Oct 26, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Oct 20, 2022 •
edited
Loading

Integration run here.

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@116db44). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             ah_var_store     #8066   +/-   ##
================================================
  Coverage                ?   86.250%           
  Complexity              ?     35205           
================================================
  Files                   ?      2173           
  Lines                   ?    165041           
  Branches                ?     17793           
================================================
  Hits                    ?    142348           
  Misses                  ?     16367           
  Partials                ?      6326

RoriCremer
RoriCremer approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@RoriCremer RoriCremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we gotta clean out that dockstore file

koncheto-broad
koncheto-broad approved these changes Oct 26, 2022
View reviewed changes
Copy link

@koncheto-broad koncheto-broad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the contents of the new expected_output folder are sound. Which look to be, by virtue of the successful integration run.

@mcovarr mcovarr merged commit 11bf415 into ah_var_store Oct 26, 2022
@mcovarr mcovarr deleted the vs_689_fix_integration_test branch October 26, 2022 19:43
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbggrant gbggrant gbggrant approved these changes

@RoriCremer RoriCremer RoriCremer approved these changes

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@rsasch rsasch Awaiting requested review from rsasch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcovarr @gbggrant @RoriCremer @koncheto-broad