Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirvana 3.18.1 Docker images support [VS-661] #8082

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Oct 31, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@31e8cb7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8082   +/-   ##
================================================
  Coverage                ?   85.912%           
  Complexity              ?     35063           
================================================
  Files                   ?      2173           
  Lines                   ?    165041           
  Branches                ?     17793           
================================================
  Hits                    ?    141790           
  Misses                  ?     16969           
  Partials                ?      6282           

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Seems pretty straightforward. I like this pattern of using a multi-stage docker builds to keep the runtimes small, and definitely suggest we do it whenever possible

@mcovarr mcovarr merged commit 18fa298 into ah_var_store Nov 1, 2022
@mcovarr mcovarr deleted the vs_661_upgrade_nirvana branch November 1, 2022 14:44
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants