"build-base" Docker image for faster variantstore image builds [VS-712] #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8085 +/- ##
================================================
Coverage ? 84.371%
Complexity ? 34536
================================================
Files ? 2173
Lines ? 165041
Branches ? 17793
================================================
Hits ? 139246
Misses ? 19641
Partials ? 6154 |
mcovarr
requested review from
gbggrant,
rsasch and
koncheto-broad
and removed request for
gbggrant
mcovarr
force-pushed
the
vs_707_azure_setup
branch
from
fbef2c1
to
51ac4b3
Compare
rsasch
reviewed
Nov 8, 2022
Can has! Please ignore the confusingness of the branch name 🙈 https://job-manager.dsde-prod.broadinstitute.org/jobs/245e1b69-a628-41c0-8e64-ebd3ae37ce30 |
Sorry if this is a dumb question, but how do I verify that the new image is being used since we can't see the WDLs of the subworkflows that are being called by the integration WDL? |
rsasch
approved these changes
Nov 8, 2022
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new "build-base" Docker image for the expensive and less frequently changed layers of the build image allowing for much improved variantstore image build times. Successful integration run here.
Other improvements:
408.0.1-alpineninja