Add flag for cost_observability table writing to support sub-cohort use case [VS-521] #8093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8093 +/- ##
================================================
Coverage ? 19.702%
Complexity ? 10708
================================================
Files ? 2173
Lines ? 164868
Branches ? 17686
================================================
Hits ? 32482
Misses ? 129238
Partials ? 3148 |
mcovarr
reviewed
Nov 16, 2022
| } | ||
|
|
||
| Boolean write_cost_to_db = if ((gvs_project != destination_project_id) || (gvs_project != query_project)) then false else true |
There was a problem hiding this comment.
TOL can this be simplified (actual question, I don't know)?
Suggested change
| Boolean write_cost_to_db = if ((gvs_project != destination_project_id) || (gvs_project != query_project)) then false else true | |
| Boolean write_cost_to_db = (gvs_project == destination_project_id) && (gvs_project == query_project) |
mcovarr
approved these changes
Nov 21, 2022
|
Github actions tests reported job failures from actions build 3516053178
|
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the
GvsExtractCohortFromSampleNamesworkflow and tweaks the handling of thecost_observabilitytable to allow it to be disabled for prepare/extract if using different Google project IDs for GVS source and sub-cohort tables (an AoU use case).Successful run: https://app.terra.bio/#workspaces/gvs-dev/RSA%20-%20GVS%20Quickstart%20V2%20/job_history/a8db0d7d-86db-48eb-8bd9-df58abd4ba3a