Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document STS delivery process for VDS [VS-727] #8101

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Nov 21, 2022

No description provided.

@gatk-bot
Copy link

gatk-bot commented Nov 21, 2022

Github actions tests reported job failures from actions build 3518744551
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 11 3518744551.11 logs
integration 11 3518744551.12 logs
unit 11 3518744551.13 logs

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@08048f1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8101   +/-   ##
================================================
  Coverage                ?   86.139%           
  Complexity              ?     35079           
================================================
  Files                   ?      2173           
  Lines                   ?    164868           
  Branches                ?     17686           
================================================
  Hits                    ?    142015           
  Misses                  ?     16519           
  Partials                ?      6334           

```

Read the baseline VDS:
Within the Python REPL created in the preceding steps, read the baseline VDS:

```python
>>> baseline_vds_path = 'gs://fc-secure-fb908548-fe3c-41d6-adaf-7ac20d541375/submissions/c86a6e8f-71a1-4c38-9e6a-f5229520641e/GvsExtractAvroFilesForHail/efb3dbe8-13e9-4542-8b69-02237ec77ca5/call-OutputPath/2022-10-19-6497f023/dead_alleles_removed_vs_667_249047_samples/gvs_export.vds'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh god must the dead_alleles_removed_vs_667_249047_sample follow us everywhere?!?!!

@@ -130,7 +91,7 @@ Yay!

## Write the filtered VDS

The following lines take 8 to 10 hours for a Delta-sized VDS using the cluster spec above. As a reminder this cluster
The following lines take several hours to execute for a Delta-scale VDS. As a reminder the specified cluster config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to just say 250k sample instead of Delta?


Once Lee has completed his QA procedure, the Variants team can begin the process of delivering the VDS to AoU. The
designated delivery bucket for AoU callsets is `gs://prod-drc-broad/`. Within the Variants team we refer to callsets
by their [NATO phonetic alphabet](https://en.wikipedia.org/wiki/NATO_phonetic_alphabet) names (e.g. Charlie, Delta, Echo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okokokok I rescind my complaint above

the [IAM page for this project](https://console.cloud.google.com/iam-admin/iam?project=terra-b3b4392d)
and granted my `[email protected]` principal a `Storage Admin` role in the `terra-b3b4392d` project:

![Firecloud Storage Admin](Firecloud%20Storage%20Admin.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for all the pngs!

@gbggrant gbggrant self-requested a review November 22, 2022 18:53
@mcovarr mcovarr merged commit 335a1b1 into ah_var_store Nov 22, 2022
@mcovarr mcovarr deleted the vs_727_document_vds_sts_xfer branch November 22, 2022 21:49
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants