Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoU cleanup docs, round 1 [VS-671] #8104

Merged
merged 20 commits into from
Jan 30, 2023
Merged

AoU cleanup docs, round 1 [VS-671] #8104

merged 20 commits into from
Jan 30, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Nov 23, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@31c3a02). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8166c60 differs from pull request most recent head 9533722. Consider uploading reports for the commit 9533722 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8104   +/-   ##
================================================
  Coverage                ?   86.246%           
  Complexity              ?     35202           
================================================
  Files                   ?      2173           
  Lines                   ?    165045           
  Branches                ?     17793           
================================================
  Hits                    ?    142345           
  Misses                  ?     16375           
  Partials                ?      6325           

@gatk-bot
Copy link

gatk-bot commented Nov 23, 2022

Github actions tests reported job failures from actions build 3533317748
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 3533317748.13 logs
integration 11 3533317748.12 logs

@gatk-bot
Copy link

gatk-bot commented Nov 23, 2022

Github actions tests reported job failures from actions build 3535155196
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 11 3535155196.11 logs
integration 11 3535155196.12 logs

@gatk-bot
Copy link

gatk-bot commented Nov 23, 2022

Github actions tests reported job failures from actions build 3535257980
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 3535257980.13 logs
integration 11 3535257980.12 logs

@gatk-bot
Copy link

Github actions tests reported job failures from actions build 3566605662
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 3566605662.13 logs

@gatk-bot
Copy link

gatk-bot commented Nov 29, 2022

Github actions tests reported job failures from actions build 3578066764
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 11 3578066764.11 logs
unit 11 3578066764.13 logs


* VDS storage cost: $500 / month. Note AoU should have exact copies of the two VDSes generated for Delta.
* VDS regeneration cost: $1000 (~10 hours @ ~$100 / hour cluster cost) + $3000 to regenerate Avro files if necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the intermediate VDS files? dont they not get cleaned up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those live in the gvs import temporary directory. The current expectation is that we would nuke that directory manually upon successful completion of the import.

@gatk-bot
Copy link

gatk-bot commented Nov 30, 2022

Github actions tests reported job failures from actions build 3587567328
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 11 3587567328.12 logs
unit 11 3587567328.13 logs

@mcovarr mcovarr force-pushed the vs_671_aou_cleanup branch 3 times, most recently from e2774d7 to 4b321f3 Compare January 14, 2023 00:07
Approximate figures for the ~250K samples Delta callset:

* VDS storage cost: ~$500 / month. Note AoU should have exact copies of the VDSes we have delivered for Delta, though
it's not certain that these copies will remain accessible to the Variants team in the long term. The Variants team has
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the Brian Freeman question? Is there someone from AoU that can verify?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we decided yesterday that we're just going to hang on to the first and last Delta VDS for now.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but 👍🏻 because this is round 1.

Comment on lines 71 to 72
GvsPrepareRangesCallset: [$1,803.14](https://docs.google.com/spreadsheets/d/1fcmEVWvjsx4XFLT9ZUsruUznnlB94xKgDIIyCGu6ryQ/edit#gid=0)
* Storing prepare data: $878.39 / month
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more helpful to have the way to calculate these numbers (e.g. number of GB * $6) in addition to the specific costs from the last run (I picked that number out of thin air).

Comment on lines 100 to 101
* ~~AI/AN filtering round one `gs://fc-secure-fb908548-fe3c-41d6-adaf-7ac20d541375/delta_ai_an_filtered_2022_11_15.vds/`~~
* ~~AI/AN filtering round two, controls removed `gs://fc-secure-fb908548-fe3c-41d6-adaf-7ac20d541375/delta_ai_an_control_filtered_2022_12_13.vds/`~~
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we keeping these in the doc if they have been deleted?

@mcovarr mcovarr merged commit e706dc0 into ah_var_store Jan 30, 2023
@mcovarr mcovarr deleted the vs_671_aou_cleanup branch January 30, 2023 22:06
RoriCremer pushed a commit that referenced this pull request Jan 31, 2023
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants