VS-759 (and VS-760) #8137
Merged
VS-759 (and VS-760) #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re tractable for our python scripts.
…es_bqloadjson_from_annotations.py
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8137 +/- ##
================================================
Coverage ? 86.242%
Complexity ? 35199
================================================
Files ? 2173
Lines ? 165045
Branches ? 17793
================================================
Hits ? 142338
Misses ? 16383
Partials ? 6324 |
mcovarr
reviewed
Jan 3, 2023
| self.assertEqual(contents, expected_contents) | ||
|
|
||
| # This test tries to read an old-style json file and verifies that the program will fail if fed such a file | ||
| @unittest.expectedFailure |
There was a problem hiding this comment.
is there a way to be sure this fails for the expected reason?
There was a problem hiding this comment.
I've updated the code to capture stderr and verify that the failure is for the expected reason.
scripts/variantstore/wdl/extract/test_create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
mcovarr
reviewed
Jan 3, 2023
scripts/variantstore/wdl/extract/test_create_genes_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
mcovarr
reviewed
Jan 3, 2023
scripts/variantstore/wdl/extract/test_create_genes_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
…m_annotations.py Co-authored-by: Miguel Covarrubias <[email protected]>
|
@mcovarr I checked the test files in compressed as I was trying to save space, but I kind of agree that it's not very necessary (and they're not that big), so will decompress. |
RoriCremer
approved these changes
Jan 4, 2023
…reate_vt_bqloadjson_from_annotations.py to support testing.
…e_genes_bqloadjson_from_annotations.py so that expected failures when trying to load old style annotations files verified that the failure was as expected (and not just a rando failure).
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more testing for create_genes_bqloadjson_from_annotations and create_vt_bqloadjson_from_annotations