-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty genes annotation file. #8153
Handle empty genes annotation file. #8153
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8153 +/- ##
================================================
Coverage ? 85.905%
Complexity ? 35059
================================================
Files ? 2173
Lines ? 165045
Branches ? 17793
================================================
Hits ? 141782
Misses ? 16981
Partials ? 6282 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits.
scripts/variantstore/wdl/extract/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/test_create_genes_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/test_create_genes_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
scripts/variantstore/wdl/extract/test_create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Bec's nits addressed 👍
Co-authored-by: Bec Asch <[email protected]>
…eGenesBqloadjson_To_handle_emptiness
* Handle empty genes annotation file. * Up CPU, and default disk and add monitoring to MergeVatTsvs task.
No description provided.