Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty genes annotation file. #8153

Merged

Conversation

gbggrant
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@498a4a6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8153   +/-   ##
================================================
  Coverage                ?   85.905%           
  Complexity              ?     35059           
================================================
  Files                   ?      2173           
  Lines                   ?    165045           
  Branches                ?     17793           
================================================
  Hits                    ?    141782           
  Misses                  ?     16981           
  Partials                ?      6282           

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits.

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Bec's nits addressed 👍

@gbggrant gbggrant merged commit fedb320 into ah_var_store Jan 12, 2023
@gbggrant gbggrant deleted the gg_AllowCreateGenesBqloadjson_To_handle_emptiness branch January 12, 2023 18:08
RoriCremer pushed a commit that referenced this pull request Jan 31, 2023
* Handle empty genes annotation file.
* Up CPU, and default disk and add monitoring to MergeVatTsvs task.
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants