Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some noise when VDS validation succeeds #8155

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jan 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@700dacd). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8155   +/-   ##
================================================
  Coverage                ?   67.594%           
  Complexity              ?     26719           
================================================
  Files                   ?      2173           
  Lines                   ?    165045           
  Branches                ?     17794           
================================================
  Hits                    ?    111561           
  Misses                  ?     48033           
  Partials                ?      5451           

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for doing this!

@RoriCremer
Copy link
Contributor

such a small change, such a different result!!!!

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcovarr mcovarr merged commit 498a4a6 into ah_var_store Jan 11, 2023
@mcovarr mcovarr deleted the update_validate_docs branch January 11, 2023 18:21
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants