VS-530 VDS creation documentation for AoU #8169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8169 +/- ##
================================================
Coverage ? 86.219%
Complexity ? 35515
================================================
Files ? 2191
Lines ? 166339
Branches ? 17901
================================================
Hits ? 143416
Misses ? 16543
Partials ? 6380 |
RoriCremer
changed the title
rsasch
requested changes
Jan 24, 2023
rsasch
reviewed
Jan 26, 2023
rsasch
reviewed
Jan 26, 2023
mcovarr
reviewed
Jan 26, 2023
Co-authored-by: Bec Asch <[email protected]>
Co-authored-by: Bec Asch <[email protected]>
Co-authored-by: Miguel Covarrubias <[email protected]>
RoriCremer
force-pushed
the
rc-vs-530-vds-documentation
branch
from
0b1a7a7
to
b051652
Compare
RoriCremer
force-pushed
the
rc-vs-530-vds-documentation
branch
from
47bbffb
to
e7400c5
Compare
mcovarr
reviewed
Jan 31, 2023
rsasch
requested changes
Jan 31, 2023
rsasch
reviewed
Feb 1, 2023
Comment on lines
87
to
89
| 1. GCS location of the VDS (the `--vds-path` input from `hail_gvs_import.py`) | ||
| 2. fully qualified name of the BigQuery dataset (composed of the `project_id` and `dataset_name` inputs from the workflows) | ||
| 3. callset statistics CSV file (see step #11 above) | ||
| 4. TSV output from `GvsCalculatePrecisionAndSensitivity` workflow (see step #12 above) | ||
| 3. CSV output from `GvsCallsetStatistics` workflow |
There was a problem hiding this comment.
Probably a good idea to link to vds/delivery/Delivering%20a%20VDS.md since that includes details of how to get the VDS to the AoU delivery bucket, naming conventions...etc.
rsasch
reviewed
Feb 2, 2023
rsasch
approved these changes
Feb 2, 2023
Co-authored-by: Bec Asch <[email protected]>
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now want to fully update the AoU documentation so that a VDS can be created (no VCFs!)