Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-694 - Extract Callset for VQSR Lite #8182

Merged
merged 18 commits into from
Feb 15, 2023
Merged

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Feb 2, 2023

Initial work on GvsExtractCallset.wdl
Minor changes to GvsCreateFilterSet.wdl and friends Create new ExtractCohortLite program for extraction of VQSR Lite data.

Minor changes to GvsCreateFilterSet.wdl and friends
Create new ExtractCohortLite program for extraction of VQSR Lite data.
Make GvsExtractCallset.wdl run using VQSR Lite or VQSR Classic
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@5b34ade). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8182   +/-   ##
================================================
  Coverage                ?   85.857%           
  Complexity              ?     35511           
================================================
  Files                   ?      2194           
  Lines                   ?    167012           
  Branches                ?     18001           
================================================
  Hits                    ?    143392           
  Misses                  ?     17233           
  Partials                ?      6387           

@gbggrant gbggrant marked this pull request as ready for review February 6, 2023 20:15
@gbggrant
Copy link
Collaborator Author

gbggrant commented Feb 7, 2023

Successful extract using VQSR Lite here
Successful extract using VQSR Classic here

…d to not load filtered sites into filter_set_info_vqsr_lite.
@@ -15,8 +15,8 @@ workflow GvsCallsetStatistics {

call Utils.ValidateFilterSetName {
input:
data_project = project_id,
dataset_name = dataset_name,
query_project = project_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going back to having the query proj being diff?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot!

# These calls to SelectVariants are being added for two reasons
# 1) The snps_variant_scored_vcf and indels_variant_scored_vcf output by JointVcfFiltering contains ALL variants,
# but are currently ONLY annotating SNPs and INDELs respectively.
# 2) Those output VCFs also contain filtered sites which we don't want to put into the filter_set_info_vqsr_lite table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "filtered sites" here mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sites in the VCF that have the filter field set to anything other than '.' or 'PASS'.

@gbggrant gbggrant merged commit ac04b54 into ah_var_store Feb 15, 2023
@gbggrant gbggrant deleted the gg_VS-694_VQSR_Lite branch February 15, 2023 20:27
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants