Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and re-format VDS -> VAT doc [VS-821] #8187

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Conversation

rsasch
Copy link

@rsasch rsasch commented Feb 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@d07e773). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8187   +/-   ##
================================================
  Coverage                ?   86.181%           
  Complexity              ?     35508           
================================================
  Files                   ?      2191           
  Lines                   ?    166339           
  Branches                ?     17901           
================================================
  Hits                    ?    143352           
  Misses                  ?     16601           
  Partials                ?      6386           

@rsasch rsasch changed the title Edit and re-format VDS -> VAT doc Edit and re-format VDS -> VAT doc [VS-821] Feb 10, 2023
@rsasch rsasch marked this pull request as draft February 10, 2023 18:32
@rsasch rsasch marked this pull request as ready for review February 10, 2023 21:00
These are the required parameters which must be supplied to the GvsCreateVATfromVDS workflow:
* `--ancestry_file` GCS pointer to the TSV file that maps `sample_name`s to sub-populations
* `--vds_path` GCS pointer to the top-level direcotory of the VDS
* `--sites_only_vcf` (optional, should be pre-populated by the `GvsExtractAvroFilesForHail` workflow) the location to write the sites-only VCF to; save this for the `GvsCreateVATfromVDS` workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooh I didn't realize this was optional...interesting

Copy link
Contributor

@RoriCremer RoriCremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rsasch rsasch merged commit 4797463 into ah_var_store Feb 13, 2023
@rsasch rsasch deleted the rsa_vet_vds_docs branch February 13, 2023 17:50
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants