Vs 822 Add documentation for the work that we did on the latest iteration of Delta #8205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8205 +/- ##
================================================
Coverage ? 83.980%
Complexity ? 34807
================================================
Files ? 2194
Lines ? 167039
Branches ? 18004
================================================
Hits ? 140279
Misses ? 20533
Partials ? 6227 |
mcovarr
reviewed
Feb 21, 2023
| pip install --force-reinstall hail==0.2.109gi | ||
| python3 | ||
|
|
||
| import hail as hl |
There was a problem hiding this comment.
this isn't where I want this though, is it?
There was a problem hiding this comment.
All of our Hail scripts should do a hl.init(tmp_dir="...") before invoking any other Hail functions, so this would seem to be the spot for that.
There was a problem hiding this comment.
can I just set it to this?:
hl.init(tmp_dir='gs://fc-secure-fb908548-fe3c-41d6-adaf-7ac20d541375/temp/')
There was a problem hiding this comment.
if that's the workspace bucket I think that should be fine
mcovarr
reviewed
Feb 21, 2023
Co-authored-by: Miguel Covarrubias <[email protected]>
rsasch
requested changes
Feb 22, 2023
rsasch
reviewed
Mar 13, 2023
|
|
||
| ## Validate it to ensure that it is ready to be shared | ||
|
|
||
| Copy the [VDS Validation python script](vds_validation.py) to the notebook environment |
There was a problem hiding this comment.
nit
Suggested change
| Copy the [VDS Validation python script](vds_validation.py) to the notebook environment | |
| Copy the [VDS Validation python script](vds_validation.py) to the notebook environment. |
mcovarr
reviewed
Mar 14, 2023
| pip install --force-reinstall hail==0.2.109 | ||
| python3 | ||
|
|
||
| >>> import hail as hl |
There was a problem hiding this comment.
Suggested change
| >>> import hail as hl | |
| >>> import hail as hl | |
| >>> hl.init(tmp_dir='gs://fc-secure-fb908548-fe3c-41d6-adaf-7ac20d541375/hail_temp') |
mcovarr
approved these changes
Mar 14, 2023
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
Bonus:
a validation script for the VDS itself