Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variants GATK Docker image building docs + script [VS-827] #8207

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Variants GATK Docker image building docs + script [VS-827] #8207

merged 4 commits into from
Feb 22, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Feb 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@5b34ade). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             ah_var_store     #8207   +/-   ##
================================================
  Coverage                ?   84.116%           
  Complexity              ?     34488           
================================================
  Files                   ?      2194           
  Lines                   ?    167012           
  Branches                ?     18001           
================================================
  Hits                    ?    140484           
  Misses                  ?     20093           
  Partials                ?      6435

RoriCremer
RoriCremer approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@RoriCremer RoriCremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing flagrantly wrong, but should I be running this? Should we do a round on mobbing?

RoriCremer
RoriCremer reviewed Feb 21, 2023
View reviewed changes
scripts/variantstore/azure/gatk_docker_setup.sh
apt-get install --assume-yes docker-ce docker-ce-cli containerd.io docker-buildx-plugin docker-compose-plugin

# Make sure this all worked with a Docker 'Hello World!' test.
docker run hello-world
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your confidence concerns me

rsasch
rsasch approved these changes Feb 22, 2023
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mcovarr
Copy link
Collaborator Author

mcovarr commented Feb 22, 2023

@RoriCremer I think it would be OK to merge this as-is and then if somebody actually needs to make a GATK jar and discovers issues with these instructions to make a follow-up ticket + PR

@mcovarr mcovarr merged commit 1ce13b3 into ah_var_store Feb 22, 2023
@mcovarr mcovarr deleted the vs_827_build_gatk_image_docs branch February 22, 2023 16:16
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoriCremer RoriCremer RoriCremer approved these changes

@rsasch rsasch rsasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @rsasch @RoriCremer