Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello Azure SQL Database from Cromwell on Azure [VS-812] #8220

Merged
merged 32 commits into from
Feb 27, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Feb 23, 2023

Say hello to Azure SQL Database from sqlcmd, Python and Java (via Ammonite) running in a Cromwell on Azure deployment. Since the Azure Batch VMs spun up by Cromwell on Azure appear to have no identity associated with them the workflow currently takes a database access token as a parameter which it passes to the three tasks.

@mcovarr mcovarr changed the title Hello Azure SQL Database [VS-812] Hello Azure SQL Database from Cromwell on Azure [VS-812] Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@fdbaa14). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8220   +/-   ##
================================================
  Coverage                ?   85.884%           
  Complexity              ?     35513           
================================================
  Files                   ?      2194           
  Lines                   ?    167012           
  Branches                ?     18001           
================================================
  Hits                    ?    143436           
  Misses                  ?     17195           
  Partials                ?      6381           

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this lives for a while, I'd want the last big block of commands and comments in the .md file to be markdown text and command lines (like the beginning of the doc).

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcovarr mcovarr merged commit 0014005 into ah_var_store Feb 27, 2023
@mcovarr mcovarr deleted the vs_812_coa_sql_database branch February 27, 2023 14:05
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants