Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove what appear to be accidentally added files [VS-834] #8225

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Feb 28, 2023

No description provided.

@gbggrant
Copy link
Collaborator

Why do you think these were accidentally added? These look like the chr20 subsetted files that @koncheto-broad uses for his slimmed down quickstart. Might actually be good for a quick testing framework some day. Or I could be completely off base!

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@0014005). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8225   +/-   ##
================================================
  Coverage                ?   85.885%           
  Complexity              ?     35518           
================================================
  Files                   ?      2194           
  Lines                   ?    167012           
  Branches                ?     18000           
================================================
  Hits                    ?    143438           
  Misses                  ?     17194           
  Partials                ?      6380           

@koncheto-broad
Copy link

Nah, this wasn't me. It looks like files that Rori added a while ago.

@mcovarr
Copy link
Collaborator Author

mcovarr commented Feb 28, 2023

Why do you think these were accidentally added?

To be more specific I think the files were not accidentally added, but multiple copies of these files were added in the 050ef8a commit in May of 2020 and I think the paths I'm removing here were not the intended paths. Copies of these files were added at the root of the GATK repo, under NA12878, and under src/test/resources/org/broadinstitute/hellbender/tools/walkers/variantutils/ReblockGVCF/NA12878. I'm planning to keep the copies at that last path and move those files to the new repo.

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context! I do like a good PR that deletes things.

@mcovarr mcovarr merged commit 6f747d0 into ah_var_store Feb 28, 2023
@mcovarr mcovarr deleted the vs_834_remove_cruft branch February 28, 2023 18:02
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants