Disentangle non-GVS code from GVS code [VS-834] #8229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
force-pushed
the
vs_834_disentangle
branch
from
5976e35
to
1a14338
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8229 +/- ##
================================================
Coverage ? 83.987%
Complexity ? 34800
================================================
Files ? 2194
Lines ? 167016
Branches ? 18003
================================================
Hits ? 140271
Misses ? 20518
Partials ? 6227 |
|
Github actions tests reported job failures from actions build 4309218748
|
gbggrant
approved these changes
Mar 2, 2023
| @@ -77,7 +76,7 @@ public static VCFFormatHeaderLine getEquivalentFormatHeaderLine(final String inf | |||
| addFilterLine(new VCFFilterHeaderLine(VCFConstants.PASSES_FILTERS_v4, "Site contains at least one allele that passes filters")); | |||
|
|
|||
| addFilterLine(new VCFFilterHeaderLine(NAY_FROM_YNG, "Considered a NAY in the Yay, Nay, Grey table")); | |||
| addFilterLine(new VCFFilterHeaderLine(EXCESS_ALLELES,"Site has an excess of alternate alleles based on the input threshold (default is " + CommonCode.EXCESS_ALLELES_THRESHOLD + ")")); | |||
| addFilterLine(new VCFFilterHeaderLine(EXCESS_ALLELES,"Site has an excess of alternate alleles based on the input threshold")); | |||
There was a problem hiding this comment.
Why did the info about the default go away?
There was a problem hiding this comment.
Good catch! 😄 Because this code is in a non-GVS package and it was reaching into a GVS package to grab that. There could be other, better ways of solving this problem.
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More prep work for separating GVS code: remove references to GVS code from non-GVS code. Integration test currently running here.