Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop tests from running when only variant store scripts are touched #8250

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Stop tests from running when only variant store scripts are touched #8250

merged 1 commit into from
Mar 21, 2023

Conversation

lbergelson
Copy link
Member

This should add an exclusion for tests so they don't run when only the var store scripts are changed.

@lbergelson lbergelson changed the title Exclue Stop tests from running when only variant store scripts are touched Mar 20, 2023
@lbergelson
Copy link
Member Author

@mcovarr This should prevent tests from triggering when only files in that subdirectory are touched. See #8252 which demonstrates the tests not runnning.

@lbergelson lbergelson marked this pull request as ready for review March 20, 2023 21:44
@lbergelson lbergelson requested a review from mcovarr March 20, 2023 21:45
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@291bfd0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f840dcb differs from pull request most recent head f8fb2ec. Consider uploading reports for the commit f8fb2ec to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##             ah_var_store     #8250   +/-   ##
================================================
  Coverage                ?   85.467%           
  Complexity              ?     35312           
================================================
  Files                   ?      2194           
  Lines                   ?    167039           
  Branches                ?     18004           
================================================
  Hits                    ?    142764           
  Misses                  ?     17923           
  Partials                ?      6352

mcovarr
mcovarr approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking this on!

@lbergelson
Copy link
Member Author

If I'd known it was an issue earlier we could have done this earlier! Sorry for your pain.

@lbergelson lbergelson merged commit bb6806b into ah_var_store Mar 21, 2023
@lbergelson lbergelson deleted the lb_exclude_gvs_scripts branch March 21, 2023 14:03
@lbergelson
Copy link
Member Author

We can always add more things to this list, I might add our README and some other things to it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcovarr mcovarr mcovarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @mcovarr