Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variants base image [VS-866] #8262

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Mar 24, 2023

Integration run kicked off here. Previous versions completed successfully but failed cost comparison because the name of the WDL step changed and was unrecognized by the branches of the comparison code that cut slack.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@c0535f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8262   +/-   ##
================================================
  Coverage                ?   85.875%           
  Complexity              ?     35516           
================================================
  Files                   ?      2194           
  Lines                   ?    167039           
  Branches                ?     18005           
================================================
  Hits                    ?    143444           
  Misses                  ?     17214           
  Partials                ?      6381           

@mcovarr mcovarr force-pushed the vs_866_update_variants_base_image branch from f58231d to ae0c7d8 Compare March 27, 2023 16:13
@@ -30,7 +30,7 @@ RUN apk add autoconf bash cmake g++ gcc make ninja python3-dev git openssl-dev z
# including the numpy Python module. The main stage will then use the same base image and copy over the artifacts
# produced by the build stage without having to install development tools or clean up after a build.

ARG ARROW_VERSION=10.0.0
ARG ARROW_VERSION=11.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to upgrade major versions of Arrow and bcftools with no changes other than these 🥳

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the integration run succeeds, 👍🏻

@mcovarr mcovarr merged commit 5e19ec0 into ah_var_store Mar 27, 2023
@mcovarr mcovarr deleted the vs_866_update_variants_base_image branch March 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants