VS-838. Remove the unneeded SCORE field from the filter_set_info_vqsr table #8278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8278 +/- ##
================================================
Coverage ? 85.882%
Complexity ? 35522
================================================
Files ? 2194
Lines ? 167029
Branches ? 18005
================================================
Hits ? 143448
Misses ? 17200
Partials ? 6381 |
mcovarr
approved these changes
Apr 5, 2023
| @@ -28,7 +28,6 @@ public final class GATKVCFConstants { | |||
| public static final String AS_CULPRIT_KEY = "AS_culprit"; | |||
| public static final String AS_VQS_LOD_KEY = "AS_VQSLOD"; | |||
| public static final String AS_VQS_SENS_KEY = "AS_VQS_SENS"; | |||
| public static final String AS_VQS_SCORE_KEY = "AS_VQS_SCORE"; | |||
There was a problem hiding this comment.
oh cool this was the source of one of the compile errors when adding GVS files to Louis's candidate GVS-to-master branch 👋
There was a problem hiding this comment.
Happy to remove unnecessary, problematic code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unneeded SCORE field from the filter_set_info_vqsr table.
The SCORE field was added to the filter_set_info_vqsr_lite table during debugging at Sam’s behest. It is the value that is used internally to determine the CALIBRATION_SENSITIVITY which is the primary ‘score’ of vqsr_lite. It can be removed now that we are done with debugging an issue we had earlier in development.