Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-883 - Add tests for extract cohort lite #8284

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

gbggrant
Copy link
Collaborator

WIP

@gbggrant gbggrant requested a review from mcovarr April 11, 2023 19:45
@gbggrant
Copy link
Collaborator Author

Think I'm going to need some avro help on one of these tests

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@e2b2e5c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8284   +/-   ##
================================================
  Coverage                ?   86.098%           
  Complexity              ?     35610           
================================================
  Files                   ?      2197           
  Lines                   ?    167119           
  Branches                ?     18006           
================================================
  Hits                    ?    143886           
  Misses                  ?     16799           
  Partials                ?      6434           

@gatk-bot
Copy link

gatk-bot commented Apr 11, 2023

Github actions tests reported job failures from actions build 4671388568
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 4671388568.13 logs
unit 8 4671388568.1 logs

@mcovarr
Copy link
Collaborator

mcovarr commented Apr 11, 2023

The ExtractCohortLiteFilterRecordUnitTest appears to be blowing up b/c it's looking for a "calibration_sensitivity" field in the src/test/resources/org/broadinstitute/hellbender/tools/gvs/extract/ExtractCohortLiteFilterRecord/test_input.avro file that's not there. Unexpectedly (for VQSR Lite) there is a "vqslod" field.

$ avro-tools getschema ~/gitrepos/gatk/src/test/resources/org/broadinstitute/hellbender/tools/gvs/extract/ExtractCohortLiteFilterRecord/test_input.avro         
23/04/11 16:22:10 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
{
  "type" : "record",
  "name" : "Root",
  "fields" : [ {
    "name" : "location",
    "type" : [ "null", "long" ]
  }, {
    "name" : "alt",
    "type" : [ "null", "string" ]
  }, {
    "name" : "ref",
    "type" : [ "null", "string" ]
  }, {
    "name" : "vqslod",
    "type" : [ "null", "double" ]
  }, {
    "name" : "yng_status",
    "type" : [ "null", "string" ]
  } ]
}

@gbggrant
Copy link
Collaborator Author

Yeah - I need to add that field to the ExtractCohortLiteRecord avro_file.

@gbggrant gbggrant marked this pull request as ready for review April 11, 2023 20:47
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this on!

@gbggrant gbggrant merged commit 4ab6bde into ah_var_store Apr 12, 2023
@gbggrant gbggrant deleted the gg_AddTestsForExtractCohortLite branch April 12, 2023 15:23
mcovarr pushed a commit that referenced this pull request Apr 12, 2023
* Adding tests for ExtractCohortLite.
mcovarr pushed a commit that referenced this pull request Apr 14, 2023
* Adding tests for ExtractCohortLite.
mcovarr pushed a commit that referenced this pull request May 2, 2023
* Adding tests for ExtractCohortLite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants