Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken gsutil in Variants Docker image [VS-888] #8289

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Apr 13, 2023

TBH I'm not sure what went wrong with the previous image, I just re-baked a new one with the current version of gcloud-sdk and that seems to be working (or at least gsutil does not immediately explode).

Test run here https://job-manager.dsde-prod.broadinstitute.org/jobs/016779a9-62d0-4195-9598-5f0eee559d99

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@4ab6bde). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8289   +/-   ##
================================================
  Coverage                ?   86.096%           
  Complexity              ?     35605           
================================================
  Files                   ?      2197           
  Lines                   ?    167119           
  Branches                ?     18007           
================================================
  Hits                    ?    143882           
  Misses                  ?     16802           
  Partials                ?      6435           

@mcovarr mcovarr marked this pull request as ready for review April 14, 2023 12:36
Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks inoffensive as a PR, but I also can't see what exactly caused or fixed the issue we saw yesterday

@mcovarr mcovarr merged commit 0f24625 into ah_var_store Apr 14, 2023
@mcovarr mcovarr deleted the vs_888_fix_broken_gsutil_docker branch April 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants