Sanity check variantstore images before publishing [VS-889] #8291
Conversation
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| if [ $# -lt 1 ]; then | |||
| echo "USAGE: ./build_build_base_docker.sh [DOCKER_TAG_STRING] [OPTIONAL:LATEST]" | |||
| echo " e.g.: ./build_build_base_docker.sh \$(date -I)-alpine-build-base" | |||
| echo " e.g.: ./build_build_base_docker.sh \$(date -Idate)-alpine-build-base" | |||
There was a problem hiding this comment.
Is this correct or a typo? What does the -Idata thing to here?
There was a problem hiding this comment.
Weird-looking but intentional. From the date man page on my machine:
-I[FMT]
Use ISO 8601 output format. FMT may be omitted, in which case the default is date. Valid FMT values are date, hours, minutes, and seconds. The date and time is
formatted to the specified precision. When FMT is hours (or the more precise minutes or seconds), the ISO 8601 format includes the timezone.
I think what we saw with @RoriCremer last week was that she had a different version of date where the FMT was mandatory. It would be great to confirm that date -Idate does work on Rori's machine.
There was a problem hiding this comment.
makes sense to me. I'd like to have her check that too, but I see why that argument is put there now. Makes the behavior you are expecting--which is the default in some implementations--explicit
There was a problem hiding this comment.
hahaha yes good idea
seems to work!
| if [[ $RC -eq 0 ]] | ||
| then | ||
| echo "Error: Tag '${TAG}' already exists for image '${BASE_REPO}', refusing to tag again." | ||
| exit 1 |
There was a problem hiding this comment.
smart--but also wont this get really annoying if we want to overwrite a docker image that we just made in error?
There was a problem hiding this comment.
ok ignore me, I just saw the next section about deleting it!
tl;dr Added sanity checks, a smoke test, and fixed sample invocations in Docker build scripts.
Last month I built a bad base image when I was unsuccessfully trying to combine GCP and Azure CLIs in one image. What's worse is I seem to have tagged this broken image with a tag previously used for a good version of the image. These changes harden the Docker image build script to refuse to write over an existing tag and execute a smoke test against the image before pushing to GCR. While I was in there I also fixed the sample invocations that we saw during mobbing did not work on all versions of
date.