Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serverless Azure SQL Database costs [VS-907] #8309

Merged
merged 17 commits into from
May 10, 2023
Merged

Serverless Azure SQL Database costs [VS-907] #8309

merged 17 commits into from
May 10, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented May 9, 2023

No description provided.

koncheto-broad
koncheto-broad approved these changes May 9, 2023
View reviewed changes
Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The initial cost projects nicely fall into "not necessarily horrible" range, which is good. In theory, with more optimizations suggested by our Microsoft partners, we might even be able to get it lower in the future.

rsasch
rsasch approved these changes May 10, 2023
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from just reading it through.

scripts/variantstore/azure/sql-database/load_azure_sql_database.sh

az group create --location eastus --resource-group "${RESOURCE_GROUP}"

# Create the server (yes serverless Azure SQL Database requires a server).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄

@mcovarr mcovarr force-pushed the vs_907_serverless_azure_sql_db_costs branch from 97a00cd to d9bdbef Compare May 10, 2023 21:01
@mcovarr mcovarr merged commit 928ffe9 into ah_var_store May 10, 2023
@mcovarr mcovarr deleted the vs_907_serverless_azure_sql_db_costs branch May 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasch rsasch rsasch approved these changes

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@gbggrant gbggrant Awaiting requested review from gbggrant

@RoriCremer RoriCremer Awaiting requested review from RoriCremer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @rsasch @koncheto-broad