Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential bug in VCF Integration test #8316

Merged
merged 2 commits into from
May 12, 2023

Conversation

gbggrant
Copy link
Collaborator

Doesn't appear to be comparing the VCFs, only the headers.

@gbggrant gbggrant requested a review from mcovarr May 12, 2023 15:29
@gbggrant
Copy link
Collaborator Author

Passing job here
Look at the logs for AssertIdenticalOutputs and you'll see that it's actually comparing the VCFs in this PR.
Previously passing run here

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that does look like a bug 😬

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@6a0b1a4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1104159 differs from pull request most recent head 20463d5. Consider uploading reports for the commit 20463d5 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8316   +/-   ##
================================================
  Coverage                ?   79.161%           
  Complexity              ?     33612           
================================================
  Files                   ?      2192           
  Lines                   ?    166470           
  Branches                ?     17917           
================================================
  Hits                    ?    131780           
  Misses                  ?     28458           
  Partials                ?      6232           

@gbggrant gbggrant merged commit 316d013 into ah_var_store May 12, 2023
@gbggrant gbggrant deleted the gg_VS-919_BugInIntegrationTest branch May 12, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants