Sl dr update docker base image #8614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationsIntegrationTest and TrainVariantAnnotationsModelIntegrationTest
samuelklee
force-pushed
the
sl_dr_update_docker_base_image
branch
from
072affd
to
4b62059
Compare
samuelklee
force-pushed
the
sl_dr_update_docker_base_image
branch
from
4b62059
to
da06b4a
Compare
samuelklee
commented
Dec 11, 2023
| @@ -72,4 +72,6 @@ RUN mkdir $DOWNLOAD_DIR && \ | |||
| bash $DOWNLOAD_DIR/miniconda.sh -p $CONDA_PATH -b && \ | |||
| rm $DOWNLOAD_DIR/miniconda.sh && \ | |||
| conda clean -afy && \ | |||
| conda config --set auto_update_conda false && \ | |||
| conda config --set solver libmamba && \ | |||
There was a problem hiding this comment.
This is not strictly needed, since libmamba is the default solver in newer conda versions, but it might be worth hinting at the new use of libmamba here.
samuelklee
commented
Dec 11, 2023
| @@ -72,4 +72,6 @@ RUN mkdir $DOWNLOAD_DIR && \ | |||
| bash $DOWNLOAD_DIR/miniconda.sh -p $CONDA_PATH -b && \ | |||
| rm $DOWNLOAD_DIR/miniconda.sh && \ | |||
| conda clean -afy && \ | |||
| conda config --set auto_update_conda false && \ | |||
There was a problem hiding this comment.
Will hopefully ensure that devs experimenting with updates to the environment within the Docker don't inadvertently update to a different conda version, which might otherwise introduce discrepancies.
|
Closing this one, since the changes proposed here were incorporated into #8610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.